Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(arma3): resolve arma3 debug not working #3409

Merged
merged 3 commits into from
Sep 23, 2021
Merged

Conversation

dgibbs64
Copy link
Member

@dgibbs64 dgibbs64 commented Mar 26, 2021

Description

Start using eval in in debug to resolve arma 3 mods issue

Fixes #3406

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed with enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

After testing the Arma3 execution method appears to no longer be required.
@dgibbs64 dgibbs64 marked this pull request as draft March 28, 2021 20:54
@dgibbs64 dgibbs64 force-pushed the hotfix/v21.2.3 branch 9 times, most recently from 47e1079 to 3f2f7b7 Compare April 3, 2021 21:16
@h3o66 h3o66 linked an issue Apr 3, 2021 that may be closed by this pull request
@dgibbs64 dgibbs64 force-pushed the hotfix/v21.2.3 branch 14 times, most recently from 70e6f9a to 079ec1e Compare April 6, 2021 09:54
Base automatically changed from hotfix/v21.2.3 to master April 6, 2021 10:02
@dgibbs64 dgibbs64 changed the base branch from master to develop July 7, 2021 15:23
@github-actions github-actions bot added the type: bug Something isn't working label Jul 7, 2021
@Marcin648
Copy link
Contributor

Marcin648 commented Sep 13, 2021

@dgibbs64 Something's wrong here.

${executable} ${parms//\\;/;}

For now it's drop any parameters because parms do not exist.
Quick change from ${parms//\\;/;} to ${startparameters//\\;/;} works for me :)
In my production environment I still on v21.2.4 and I use printf "%q" for escape mods. Maybe it will be helpful.

@Marcin648 Marcin648 mentioned this pull request Sep 14, 2021
13 tasks
@dgibbs64 dgibbs64 added this to the v21.3.0 milestone Sep 23, 2021
@dgibbs64 dgibbs64 marked this pull request as ready for review September 23, 2021 22:25
@dgibbs64 dgibbs64 merged commit ef3f752 into develop Sep 23, 2021
@dgibbs64 dgibbs64 deleted the feature/arma3-mods branch September 23, 2021 22:39
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Arma 3 debug does not load with startup parameters
2 participants