Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace deprecated optparse with argparse #3913

Merged
merged 1 commit into from
Aug 23, 2022
Merged

fix: replace deprecated optparse with argparse #3913

merged 1 commit into from
Aug 23, 2022

Conversation

eggplants
Copy link
Contributor

Description

I replaced optparse with argparse and refactored some process to check arguments.

Breaking change: Status code 4 no longer occurs because argparse checks whether an argument is passed.

Fixes #3912

Type of change

  • New feature (change which adds functionality).
  • Refactor (restructures existing code).

Checklist

PR will not be merged until all steps are complete.

@h3o66 h3o66 linked an issue Jul 8, 2022 that may be closed by this pull request
@h3o66 h3o66 added this to the v22.2.0 milestone Aug 22, 2022
@dgibbs64 dgibbs64 merged commit 81998f7 into GameServerManagers:develop Aug 23, 2022
@eggplants eggplants deleted the replace_optparse branch August 23, 2022 21:07
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] query_gsquery.py: replace optparse with argparse
3 participants