updates from upstream #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… assignment expression
```js
let param = 'default value';
if (object)
param = object.param; // <= prefer-destructuring
}
// ...
```
I think that `param = object.param;` is better than `({ param } = object);` because it is easier to read and tedious to write brackets by hand.
MDN: [Destructuring assignment](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Destructuring_assignment)
…ors` - adds warning on mixing `/` and `*` arithmetic operators - removes warnings on mixing `**` and arithmetic operators - removes warning on mixing `in` and `instanceof` - removes warning on mixing `~` with other bitwise operators - removes mixing of assignment operators with comparison operators
This enables the `strict` rule in 'safe' mode: https://eslint.org/docs/rules/strict#safe
Previously `rules/strict.js` was only used by `eslint-config-airbnb` and not base. This change reduces the duplication, and means the rule is now set to 'never' as opposed to the ESLint default of 'safe'. For users that left the `sourceType` at this preset's default of `module` this change will be a no-op, since in module-mode the `strict` rule always behaves as though 'never' had been set. See: https://eslint.org/docs/rules/strict#options
Since the file is now imported in base instead. Fixes #1582.
…Restrict empty lines at beginning of file
…eLineBlocks` option
…derPropertyDescriptor` option
Co-authored-by: Jordan Harband <ljharb@gmail.com>
The recommendation is to declare the variables, classes and functions before. So the contrasting negative example should say after.
This removes the `object.entries` package and uses the widely available built-in native `Object.entries`.
…expression values
… have `navigation` role
Signed-off-by: Kim Minh Thắng <thangved02@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates from upstream repo for guidelines on react