Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failed on Windows. Changes enable cross-platform build #188

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Build failed on Windows. Changes enable cross-platform build #188

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
211e2fe
Partial fix for bug #1
avnir-cs Jul 6, 2022
e998fa9
Fixed bug #1
avnir-cs Jul 6, 2022
c106534
Bumping cross-env version to 7.0.3
avnir-cs Jul 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"arrow-parens": ["error", "as-needed"],
"comma-dangle": ["error", "never"],
"indent": ["error", 2],
"linebreak-style": ["error", "unix"],
"linebreak-style": 0,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you tell me a little more about this. I hadn't paid much attention to this recently. I think we still want to keep a consistent line break approach ("\n"), but I'm open to discussion. What does setting "linebreak-style" to zero achieve? I think there's ways to do \n and not \r\n on Windows machines when you are using vscode...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not that strict about linebreak-style really, as I don't think it affects much except how things look on different editors/ides. Github check-in/check-out can also change linebreaks depending on your github settings, to allow for platform independent development. So, likebreak-style being inconsistent should be warning, rather than error.

Having said all that, the change I made, i.e. linebreak-style: 0, essentially disables linebreak-style checks. Don't know how to make it into a platform dependent warning, so that, if you're working on Windows, it warns if linebreaks are not Windows style, and if you're working on Unix, then it warns on non-Unix line breaks.

Do we even need to check linebreak styles for build as it doesn't affect output and code minifying removes them anyway.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this?
"linebreak-style": ["error", (process.platform === "win32" ? "windows" : "unix")]

This should throw error only if the linebreak style is not appropriate for the platform you're working on.

Source: https://stackoverflow.com/a/53110172

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would still lead to inconsistencies between platforms, which I'm hoping to avoid. Would you be able to add an . editorconfig instead?

"no-console": "off",
"no-multiple-empty-lines": "error",
"no-unused-vars": ["error", { "args": "none" }],
Expand Down
Loading