Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate the need for the custom render texture creation function #5

Merged
merged 1 commit into from
May 29, 2023

Conversation

patrickdown
Copy link
Collaborator

@patrickdown patrickdown commented May 19, 2023

Use ImageTexture and Texture2dArray objects instead of the custom texture_create_render_texture function

This is dependent on Godot PR #77224

@patrickdown patrickdown requested a review from BastiaanOlij May 19, 2023 11:23
Copy link
Member

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BastiaanOlij
Copy link
Member

Guess we want to wait with merging this until upstream is merged.
Also we should remove the patch related to the render texture in this PR.

Use ImageTexture and Texture2dArray objects instead of the custom texture_create_render_texture function

Amend:
Update patches to remove texture_create_render_texture
@patrickdown patrickdown force-pushed the refactor_texture_creation branch from b52dcc8 to 2193401 Compare May 19, 2023 11:40
@patrickdown patrickdown self-assigned this May 19, 2023
@patrickdown patrickdown merged commit f33fd22 into GodotVR:main May 29, 2023
@patrickdown
Copy link
Collaborator Author

Godot PR 77224 was merged

@patrickdown patrickdown deleted the refactor_texture_creation branch May 29, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants