Added frame rate control. #364
Merged
+44
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup white-space
Malcolmnixon
force-pushed
the
frame-rate-control
branch
from
1f681cf to
1982f26
Compare
BastiaanOlij
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes issue #363 by giving the user the ability to specify a target frame-rate.
This code always tries to set the frame-rate (if supported). It picks a desired frame-rate of the users specified target frame-rate; or if it's not specified (a value of 0.0) then it will pick the frame-rate reported by the device. It then picks the closest frame-rate supported by the device and sets the device to run at that rate.
In the case where the quest lies and reports 90Hz when it's actually running at 72Hz, the value of 90Hz will be picked as the desired rate and the quest will then be set to run at that rate.