Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added frame rate control. #364

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

Malcolmnixon
Copy link
Collaborator

This pull request fixes issue #363 by giving the user the ability to specify a target frame-rate.

This code always tries to set the frame-rate (if supported). It picks a desired frame-rate of the users specified target frame-rate; or if it's not specified (a value of 0.0) then it will pick the frame-rate reported by the device. It then picks the closest frame-rate supported by the device and sets the device to run at that rate.

In the case where the quest lies and reports 90Hz when it's actually running at 72Hz, the value of 90Hz will be picked as the desired rate and the quest will then be set to run at that rate.

Cleanup white-space
Copy link
Member

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We probably should make a similar change to our firstpersoncontroller in the openxr plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants