-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Ports URL markdown linter rules from web.dev #1901
Conversation
✔️ Deploy Preview for developer-chrome-com ready! 🔨 Explore the source changes: 65e6756 🔍 Inspect the deploy log: https://app.netlify.com/sites/developer-chrome-com/deploys/61d6034dd6dac20008b4059a 😎 Browse the preview: https://deploy-preview-1901--developer-chrome-com.netlify.app |
Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated. Requested changesIf there are any common problems with the content files you created or modified, they will be listed here.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only speaking for the JS code, this looks good. I'm assuming all of the MD changes are adjustments based on the linter, but I'd rather leave that for the tech writing team to review. I am happy with the JS though.
Yup, the MD adjustments are just to satisfy the added linter warnings. I did my best to make sure my search/replace patterns were as limited as possible, but if we need to fix something down the line, we can. In my experience, these changes didn't seem to break anything on web.dev. Mergin'! |
web.dev has a number of markdown linter rules that the tech writers team finds useful for eliminating repetitive review tasks. This PR ports those rules from web.dev, which include:
developer.mozilla.org
is linked to rather thanwiki.developer.mozilla.org
.