Skip to content
This repository was archived by the owner on Mar 14, 2024. It is now read-only.

feat(types): get defaut values from @default tag #1930

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Conversation

MichaelSolati
Copy link
Contributor

Changes proposed in this pull request:

  • Add switch case to external/build/lib/dts-parse.js to store the value of @default to node._feautre.
  • Render node._feature.default when rendering single icon type.

@netlify
Copy link

netlify bot commented Jan 10, 2022

✔️ Deploy Preview for developer-chrome-com ready!

🔨 Explore the source changes: 4bdd132

🔍 Inspect the deploy log: https://app.netlify.com/sites/developer-chrome-com/deploys/61dcaaa92760d4000802ca16

😎 Browse the preview: https://deploy-preview-1930--developer-chrome-com.netlify.app

@pullapprove pullapprove bot requested a review from devnook January 10, 2022 21:52
Copy link
Contributor

@jeffposnick jeffposnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MichaelSolati MichaelSolati merged commit 3729791 into main Jan 10, 2022
@MichaelSolati MichaelSolati deleted the feat/types branch January 10, 2022 21:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants