fix: prevent disabling apis on destroy #296
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per hashicorp/terraform-provider-google#18058, the default value of
google_project_service.disable_on_destroy
can be destructive if applying the terraform to an existing GCP project with resource defined outside of it. See related docs also. This PR sets it tofalse
explicitly.It also swaps the use of
google_project_iam_binding
andgoogle_storage_bucket_iam_binding
forgoogle_project_iam_member
andgoogle_storage_bucket_iam_member
respectively as they too can result in destructive changes to existing resources (see hashicorp/terraform-provider-google#5760 and hashicorp/terraform-provider-google#10903).