Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom kaniko image is ignored #1586

Closed
everflux opened this issue Feb 1, 2019 · 2 comments · Fixed by #1588
Closed

Custom kaniko image is ignored #1586

everflux opened this issue Feb 1, 2019 · 2 comments · Fixed by #1588
Labels
kind/bug Something isn't working

Comments

@everflux
Copy link

everflux commented Feb 1, 2019

Expected behavior

When specifying build.kaniko.image it is possible to choose a custom image instead of the default gcr.io/kaniko-project/executor:v0.7.0@sha256:0b4e08... image.

Actual behavior

The default image is always used.

Information

  • Skaffold version: v.0.22.0
  • Operating system: linux
  • Contents of skaffold.yaml:
apiVersion: skaffold/v1beta4
kind: Config
build:
  artifacts:
  - image: localhost:31000/kaniko-demo
  kaniko:
    buildContext:
      localDir: {}
    Image: localhost:31000/kaniko/executor
    namespace: default
    cache: {}
deploy:
  kubectl:
    manifests:
    - k8s-*

Steps to reproduce the behavior

  1. skaffold run produces a pod with the (pinned) default skaffold executor image
@priyawadhwa priyawadhwa added the kind/bug Something isn't working label Feb 2, 2019
priyawadhwa pushed a commit to priyawadhwa/skaffold-1 that referenced this issue Feb 2, 2019
fixes GoogleContainerTools#1586, previously we were using the default image instead of the image passed in through the config.
@priyawadhwa
Copy link
Contributor

Hey @everflux , I think I introduced this bug when refactoring kaniko, sorry about that! I've opened a PR to fix it.

@everflux
Copy link
Author

everflux commented Feb 2, 2019

I tested with a local skaffold build and it fixes the issue, thanks for the really awesome quick turn around!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants