Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skaffold YAML reference page broken #3618

Closed
briandealwis opened this issue Jan 31, 2020 · 1 comment · Fixed by #3620
Closed

Skaffold YAML reference page broken #3618

briandealwis opened this issue Jan 31, 2020 · 1 comment · Fixed by #3620
Assignees
Labels
area/docs kind/bug Something isn't working priority/p0 Highest priority. We are actively looking at delivering it.

Comments

@briandealwis
Copy link
Member

The skaffold.yaml reference page is broken. It appears to be related to the update of lit-html in #3466

The code is breaking at line 110:

} else if ((definition.type === 'array') && value && (value !== '[]')) {
// Parse value to json array
const values = JSON.parse(value);

value is "." from the default value of the KustomizeDeploy's paths property, which is defined as an array of strings.

"paths": {
"items": {
"type": "string"
},
"type": "array",
"description": "path to Kustomization files.",
"x-intellij-html-description": "path to Kustomization files.",
"default": "."
}

And sure enough, "." isn't an array of strings.

But this default hasn't changed in ages, so it must be the lit-html. What's puzzling is why this error didn't show up during testing of #3466?

@briandealwis briandealwis added kind/bug Something isn't working area/docs labels Jan 31, 2020
@balopat balopat added the priority/p0 Highest priority. We are actively looking at delivering it. label Jan 31, 2020
@balopat balopat self-assigned this Jan 31, 2020
@balopat
Copy link
Contributor

balopat commented Jan 31, 2020

Thank you for the analysis, @briandealwis! There was a kustomize change (#3585) that went in after the lit-html change that changed the type of kustomize paths to array of strings from string. I believe the issue is with the default value setting there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs kind/bug Something isn't working priority/p0 Highest priority. We are actively looking at delivering it.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants