-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable multiple kustomizations in the kustomize deployer #3585
Enable multiple kustomizations in the kustomize deployer #3585
Conversation
Codecov Report
|
f3ea6b4
to
31ec48f
Compare
Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
PRs GoogleContainerTools#3577 and GoogleContainerTools#3578 introduced a conflict with respect to trailing newlines.
31ec48f
to
eac30aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, thank you @corneliusweig! And thanks for fixing the init_test.go bug - our lines has crossed there somehow with out of order PR merges or something.
Fixes #1872.
Description
So far, the kustomize deployer only accepted a single path to a kustomization folder. This required an umbrella kustomization when working with multiple kustomization folders. On the other hand, for helm it has always been possible to deploy multiple charts, so that the UX between the differnent deployers was kind of inconsistent as pointed out in #1872.
Therefore, this PR enables multiple kustomization folders/paths in a single deployer stanza.
User facing changes
The (
string
) key changed todeploy.kustomize.paths
([]string
). When not specified, it defaults to[]string{"."}
and behaves equivalently to the previous config version.Before
The pipeline had a key
deploy.kustomize.path
of typestring
to specify a single kustomization folder. When empty it defaults to"."
.After
The pipeline has a key
deploy.kustomize.paths
of type[]string
to specify a multiple kustomization folders. When empty (nil
or length zero) it defaults to[]string{"."}
.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Reviewer Notes
Release Notes