Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to suppress status check output when configured #4516

Closed
nkubala opened this issue Jul 21, 2020 · 3 comments · Fixed by #4907
Closed

Add ability to suppress status check output when configured #4516

nkubala opened this issue Jul 21, 2020 · 3 comments · Fixed by #4907

Comments

@nkubala
Copy link
Contributor

nkubala commented Jul 21, 2020

depends on #4512

wire up flag/config option to suppress status check output in favor of status.

@nkubala nkubala added kind/feature-request area/ux priority/p0 Highest priority. We are actively looking at delivering it. area/logging july-chill labels Jul 21, 2020
@tstromberg tstromberg added needs-design-proposal priority/p2 May take a couple of releases and removed priority/p0 Highest priority. We are actively looking at delivering it. labels Aug 5, 2020
@tejal29
Copy link
Contributor

tejal29 commented Aug 14, 2020

As part of this work, Identify

  • what statuses are important and worth notifying about
  • If we do identify nothing interesting happened, what is reasonable amount of time to wait until we show some output
  • do events also need to apply the same rule?

Previously, when designing status checks, we decided to show all new status updates every half secons.

after adding pod status health checks, the number of new statuses increases. Not all statuses are interesting like "container creating" or "pod initializing"
we also had a regressions where for deployment waiting for rollout was reported repeatedly.

@nkubala nkubala added this to the v1.14.0-friction milestone Aug 14, 2020
@nkubala
Copy link
Contributor Author

nkubala commented Sep 2, 2020

@tejal29 what follow up work needs to be done here?

@nkubala nkubala modified the milestones: v1.14.0-friction, v1.15.0 Sep 2, 2020
@nkubala nkubala modified the milestones: v1.15.0, v1.16.0 Oct 1, 2020
@tejal29
Copy link
Contributor

tejal29 commented Oct 13, 2020

So on master

➜  microservices git:(master) ✗ ../../out/skaffold dev --mute-logs=status-check,build 
Listing files to watch...
 - leeroy-web
 - leeroy-app
Generating tags...
 - leeroy-web -> leeroy-web:v1.15.0-15-gc6260e8b5
 - leeroy-app -> leeroy-app:v1.15.0-15-gc6260e8b5
Checking cache...
 - leeroy-web: Not found. Building
 - leeroy-app: Not found. Building
Found [minikube] context, using local docker daemon.
Building [leeroy-web]...
 - writing logs to /var/folders/gk/s778hvkj0lb0zl95ywvw0snr00cfc0/T/skaffold/build/leeroy-web.log
Building [leeroy-app]...
 - writing logs to /var/folders/gk/s778hvkj0lb0zl95ywvw0snr00cfc0/T/skaffold/build/leeroy-app.log
Tags used in deployment:
 - leeroy-web -> leeroy-web:c0e26baa031172e4c4de052dee8dd407d1034a1f2bb626eb9e9cf5379d7176f5
 - leeroy-app -> leeroy-app:e07eb9ac125d12cbaa0ecef6c6947e3eeb40b289491778d9d2ffe48687b9fa77
Starting deploy...
 - deployment.apps/leeroy-web created
 - service/leeroy-app created
 - deployment.apps/leeroy-app created
Waiting for deployments to stabilize...
 - deployment/leeroy-app is ready. [1/2 deployment(s) still pending]
 - deployment/leeroy-web is ready.
Deployments stabilized in 4.06119592s

So i see the status-check output on the terminal and not written to the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants