Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mute status check logs #4907

Merged
merged 2 commits into from
Oct 19, 2020
Merged

mute status check logs #4907

merged 2 commits into from
Oct 19, 2020

Conversation

tejal29
Copy link
Contributor

@tejal29 tejal29 commented Oct 13, 2020 •
edited
Loading

Fixes #4516

Wire up status check to mute logs if --mute-log=status-check is present.

Testing notes:

  1. run make
  2. ../../out/skaffold dev --mute-logs=status-check
....
Waiting for deployments to stabilize...
- writing logs to /var/folders/gk/s778hvkj0lb0zl95ywvw0snr00cfc0/T/skaffold/status-check/2020-10-13_16-12-10.log
Press Ctrl+C to exit
Watching for changes...
[leeroy-app] 2020/10/13 22:51:13 leeroy app server ready
[leeroy-web] 2020/10/13 22:51:13 leeroy web server ready
  1. Verify the log contents.

➜  github-dashing git:(docker-support) ✗ cat /var/folders/gk/s778hvkj0lb0zl95ywvw0snr00cfc0/T/skaffold/status-check/2020-10-13_16-12-10.log
Waiting for deployments to stabilize...
 - deployment/leeroy-web is ready. [1/2 deployment(s) still pending]
 - deployment/leeroy-app is ready.
Deployments stabilized in 2.611142551s
➜  github-dashing git:(docker-support) ✗

@tejal29 tejal29 requested a review from a team as a code owner October 13, 2020 23:16
@tejal29 tejal29 requested a review from MarlonGamez October 13, 2020 23:16
@google-cla google-cla bot added the cla: yes label Oct 13, 2020
@codecov
Copy link

codecov bot commented Oct 13, 2020 •
edited
Loading

Codecov Report

Merging #4907 into master will increase coverage by 0.23%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4907      +/-   ##
==========================================
+ Coverage   71.96%   72.20%   +0.23%     
==========================================
  Files         357      358       +1     
  Lines       12327    12421      +94     
==========================================
+ Hits         8871     8968      +97     
+ Misses       2799     2797       -2     
+ Partials      657      656       -1
Impacted Files Coverage Δ
pkg/skaffold/runner/deploy.go 43.93% <66.66%> (+1.31%) ⬆️
pkg/skaffold/deploy/util/logfile.go 80.00% <80.00%> (ø)
pkg/skaffold/build/gcb/kaniko.go 77.77% <0.00%> (-4.58%) ⬇️
pkg/skaffold/errors/err_map.go 96.66% <0.00%> (-3.34%) ⬇️
pkg/skaffold/sync/sync.go 70.27% <0.00%> (-1.46%) ⬇️
pkg/skaffold/build/cluster/pod.go 86.56% <0.00%> (-1.01%) ⬇️
pkg/skaffold/build/jib/maven.go 100.00% <0.00%> (ø)
pkg/skaffold/build/jib/gradle.go 100.00% <0.00%> (ø)
pkg/skaffold/util/env_template.go 100.00% <0.00%> (ø)
pkg/skaffold/errors/buildProblems.go 100.00% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6260e8...51ddc71. Read the comment docs.

briandealwis
briandealwis approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@briandealwis briandealwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two optional things to consider.

Funnily enough, the muted output is written out with ANSI sequences (#4913).

@tejal29 tejal29 merged commit 331da68 into GoogleContainerTools:master Oct 19, 2020
@fmotrifork fmotrifork mentioned this pull request Nov 2, 2020
Merged
tejal29 added a commit that referenced this pull request Mar 3, 2021
@tejal29
Add defer and close status-check log file correctly
5346b74 
In, #4907 @briandealwis had left code review comments to 
1) move `postStatusCheckFn()` as soon as it got defined and 
2) add a defer.
I only addressed part 1 creating a bug. 
Now addressing part 2. 

Thanks @nkubala for bringing this to my attention.
@tejal29 tejal29 mentioned this pull request Mar 3, 2021
Merged
MarlonGamez pushed a commit that referenced this pull request Mar 8, 2021
@tejal29
Add defer and close status-check log file correctly (#5486)
2cc744d 
In, #4907 @briandealwis had left code review comments to 
1) move `postStatusCheckFn()` as soon as it got defined and 
2) add a defer.
I only addressed part 1 creating a bug. 
Now addressing part 2. 

Thanks @nkubala for bringing this to my attention.
@tejal29 tejal29 deleted the mute_status_check branch April 15, 2021 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandealwis briandealwis briandealwis approved these changes

@MarlonGamez MarlonGamez Awaiting requested review from MarlonGamez

Assignees
No one assigned
Labels
cla: yes size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ability to suppress status check output when configured
2 participants
@tejal29 @briandealwis