Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support '--squash' option in 'docker build' #5076

Closed
savyasachi9 opened this issue Nov 27, 2020 · 0 comments · Fixed by #5078
Closed

Support '--squash' option in 'docker build' #5076

savyasachi9 opened this issue Nov 27, 2020 · 0 comments · Fixed by #5078
Labels
area/build kind/feature-request priority/p3 agreed that this would be good to have, but no one is available at the moment.

Comments

@savyasachi9
Copy link
Contributor

savyasachi9 commented Nov 27, 2020

Background

docker 'build' supports '--squash' as an option which helps in reducing the size of docker image by squashing multiple layers into one
--squash Squash newly built layers into a single new layer

Feature request

It'd be great if Skaffold support this too, so I played with Skaffold code by referencing below PRs and got '--squash' working

I am submitting PRs to add support for '--squash' since I already have working code for it

  • i still have to add error for 'google cloud build/gcb' which doesn't support '--squash' I believe

here's the PR :
#5078

@gsquared94 gsquared94 added area/build kind/feature-request priority/p3 agreed that this would be good to have, but no one is available at the moment. labels Dec 2, 2020
tejal29 pushed a commit that referenced this issue Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build kind/feature-request priority/p3 agreed that this would be good to have, but no one is available at the moment.
Projects
None yet
2 participants