Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skaffold status-check should happen after individual deploy actions #5774

Closed
gsquared94 opened this issue May 3, 2021 · 0 comments · Fixed by #6115
Closed

Skaffold status-check should happen after individual deploy actions #5774

gsquared94 opened this issue May 3, 2021 · 0 comments · Fixed by #6115
Assignees

Comments

@gsquared94
Copy link
Contributor

Skaffold status-check currently runs after all deploy operations have completed. This could mean that in a multi-config project defining hierarchical (like database, svc A using database, svc B using svc A, and so on) deploy stanzas, skaffold doesn't wait for a resource deployment to become stable before moving on to the next deployment.

As a result there's no real benefit to the topological ordered deployments for real-world services that take time to stabilize.

To fix this, status check should be run after each deploy.<deployer_type> execution. For instance, for the deploy stanza:

metadata:
   name: cfg1
...
deploy:
  kubectl:
    ...
---
metadata:
   name: cfg2
requires:
  - configs: [cfg1]
...
deploy:
  helm:
    ...```

There should be a status-check after the cfg1.deploy.kubectl deployment and again after cfg2.deploy.helm deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants