Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 5774: Allow iterative status checks #6115

Merged
merged 2 commits into from
Jul 1, 2021

Conversation

gsquared94
Copy link
Contributor

Fixes: #5774
Related: #6044

Description

Using the --iterative-status-check flag, users can enforce that skaffold does a status-check after every individual deployer runs.

User facing changes (remove if N/A)

New flag --iterative-status-check.

@gsquared94 gsquared94 requested a review from nkubala June 30, 2021 18:57
@gsquared94 gsquared94 requested a review from a team as a code owner June 30, 2021 18:57
@google-cla google-cla bot added the cla: yes label Jun 30, 2021
@gsquared94 gsquared94 added the docs-modifications runs the docs preview service on the given PR label Jun 30, 2021
@container-tools-bot
Copy link

Please visit http://35.235.78.86:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Jun 30, 2021
Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a few comments

@codecov
Copy link

codecov bot commented Jun 30, 2021

Codecov Report

Merging #6115 (7665209) into master (b8124d0) will decrease coverage by 0.07%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6115      +/-   ##
==========================================
- Coverage   70.21%   70.13%   -0.08%     
==========================================
  Files         475      475              
  Lines       18142    18201      +59     
==========================================
+ Hits        12739    12766      +27     
- Misses       4469     4491      +22     
- Partials      934      944      +10     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/flags.go 89.28% <ø> (ø)
pkg/skaffold/config/options.go 100.00% <ø> (ø)
pkg/skaffold/deploy/deploy_mux.go 54.38% <28.57%> (-3.62%) ⬇️
pkg/skaffold/runner/v1/deploy.go 49.41% <75.00%> (+0.01%) ⬆️
pkg/skaffold/runner/deployer.go 59.03% <100.00%> (ø)
pkg/skaffold/runner/runcontext/context.go 85.36% <100.00%> (+0.11%) ⬆️
pkg/skaffold/access/provider.go 26.66% <0.00%> (-23.34%) ⬇️
pkg/skaffold/util/tar.go 50.66% <0.00%> (-5.34%) ⬇️
pkg/skaffold/schema/validation/validation.go 84.44% <0.00%> (-2.20%) ⬇️
pkg/skaffold/instrumentation/export.go 61.69% <0.00%> (-1.77%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8124d0...7665209. Read the comment docs.

@gsquared94 gsquared94 added the kokoro:force-run forces a kokoro re-run on a PR label Jul 1, 2021
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Jul 1, 2021
@gsquared94 gsquared94 requested a review from nkubala July 1, 2021 09:00
@gsquared94 gsquared94 merged commit fe12a8a into GoogleContainerTools:master Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skaffold status-check should happen after individual deploy actions
4 participants