Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skaffold init --generate-manifests --force does not have a way to non-interactively specify exposed ports #6248

Closed
j-windsor opened this issue Jul 19, 2021 · 3 comments

Comments

@j-windsor
Copy link

j-windsor commented Jul 19, 2021

Expected behavior

The command allows for a flag (perhaps --port-forward=[] where a non-interactive user (aka a Cloud Code user) can specify ports for each of the images that will be built.

Actual behavior

The command outputs port 8080 in each of the manifest files and skaffold.yaml port forwards section regardless of what the actual exposed port is. The user should have an opportunity to specify this.

Information

  • Skaffold version: v1.27.0
  • Operating system: MacOS Big Sur 11.4
  • Installed via: Google Cloud SDK
  • Contents of skaffold.yaml: n/a

Steps to reproduce the behavior

  1. Clone https://github.com/GoogleCloudPlatform/cloud-code-samples/tree/master/nodejs/nodejs-hello-world
  2. Delete skaffold.yaml and k8s manifests
  3. Change port from 8080
  4. skaffold init --generate-manifests --force
  5. skaffold dev
  6. App fails to load
@j-windsor
Copy link
Author

@briandealwis mentioned that buildpacks assumes that the app is running on port 8080, so since there is a precedent set for this, we might be able to do the same. In this case, Cloud Code would just have a text blurb saying that it will assume the app is running on 8080.

@MarlonGamez
Copy link
Contributor

Seems we need to design and expose some sort of API to allow non interactive use of --generate-manifests I'll look into this and be in contact @j-windsor

@tejal29 tejal29 added this to the v1.32.0 milestone Aug 13, 2021
@tejal29 tejal29 added priority/p1 High impact feature/bug. and removed priority/p2 May take a couple of releases labels Aug 16, 2021
@MarlonGamez MarlonGamez self-assigned this Aug 30, 2021
@MarlonGamez
Copy link
Contributor

closing this as we now have a non-interactive way to expose ports in #6599

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants