Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend --artifact API schema to allow for manifest generation #6599

Merged

Conversation

MarlonGamez
Copy link
Contributor

@MarlonGamez MarlonGamez commented Sep 13, 2021

Fixes: #6249, #6248

Description
CC: @briandealwis @j-windsor

Users can now generate manifests using the --artifact (or -a) flag by passing some additional information in their json objects.

The schema changes are as follows:
Before:

{
  "builder": string,
  "payload": {
    "path": string,
  },
  "image": string,
},

After:

{
  "builder": string,
  "payload": {
    "path": string,
  },
  "image": string,
  "manifest-info:": {
    "path": string,
    "port": int,
  },
}

Follow-up Work
Document this feature

@MarlonGamez MarlonGamez requested a review from a team as a code owner September 13, 2021 22:07
@MarlonGamez MarlonGamez requested a review from nkubala September 13, 2021 22:07
@google-cla google-cla bot added the cla: yes label Sep 13, 2021
@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #6599 (f6178c3) into main (290280e) will decrease coverage by 0.14%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6599      +/-   ##
==========================================
- Coverage   70.48%   70.34%   -0.15%     
==========================================
  Files         515      517       +2     
  Lines       23150    23326     +176     
==========================================
+ Hits        16317    16408      +91     
- Misses       5776     5853      +77     
- Partials     1057     1065       +8     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/flags.go 90.81% <ø> (ø)
cmd/skaffold/skaffold.go 0.00% <ø> (ø)
pkg/skaffold/build/buildpacks/logger.go 0.00% <ø> (ø)
pkg/skaffold/config/options.go 100.00% <ø> (ø)
pkg/skaffold/debug/apply_transforms.go 22.64% <0.00%> (-0.44%) ⬇️
pkg/skaffold/debug/transform.go 95.91% <ø> (ø)
pkg/skaffold/docker/logger/log.go 22.64% <0.00%> (-0.44%) ⬇️
pkg/skaffold/initializer/build/builders.go 42.85% <0.00%> (-17.15%) ⬇️
pkg/skaffold/initializer/build/util.go 94.44% <0.00%> (-5.56%) ⬇️
pkg/skaffold/kubectl/exec.go 100.00% <ø> (ø)
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d306e4...f6178c3. Read the comment docs.

Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code generally looks good, one question about the ports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

skaffold init --analyze --generate-manifests does not emit images
3 participants