Skaffold fails to label API objects created with multi-document JSON k8s manifest

[nkubala]

Expected behavior

Skaffold correctly labels all API objects in kubernetes

Actual behavior

Labeling on the API objects created through the JSON manifests fails. The objects are created successfully (aka deployment succeeds), but labeling fails with:

Starting deploy...
service/leeroy-app created
deployment.apps/leeroy-app created
service/leeroy-app unchanged
deployment.apps/leeroy-app unchanged
service/leeroy-web created
deployment.apps/leeroy-web created
WARN[0005] error adding label to runtime object: getting metadata accessor: object does not implement the Object interfaces 
Deploy complete in 2.248206572s

I deployed to GKE, so inspecting the Service in the cloud console, I can see that there are no labels on the leeroy-app service, but they are there on leeroy-web (which was deployed from YAML).

Information

• Skaffold version: v0.12.0
• Operating system: Debian 4.9.82
• Contents of skaffold.yaml: see examples/microservices/skaffold.yaml

Steps to reproduce the behavior

1. In the microservices example in Skaffold, rewrite the leeroy-app/kubernetes/deployment.yaml to deployment.json as follows (abbreviated since this is just a rewrite of the bundled example):

{
    "apiVersion": "v1",
    "kind": "List",
    "metadata": {},
    "items": [
        {
            "apiVersion": "v1",
            "kind": "Service",
            ...
        },
        {
            "apiVersion": "apps/v1",
            "kind": "Deployment",
            "metadata": {
                "name": "leeroy-app",
                "labels": {
                    "app": "leeroy-app"
                }
            },
            "spec": {
                "replicas": 1,
                "selector": {
                    "matchLabels": {
                        "app": "leeroy-app"
                    }
                },
               ...
            }
        }
    ]
}

2. Do a skaffold dev or skaffold run.

My guess is this has something to do with using kind: List since JSON doesn't support the k8s document separator (---).

[dgageot]

This was fixed by a combination of #1451 and #1489