Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use kubectl to read the manifests #1451

Merged
merged 2 commits into from
Jan 29, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jan 11, 2019

  • Adds support for json manifests
  • Should help when kustomize is built into kubectl

Fixes #921

Signed-off-by: David Gageot david@gageot.net

@dgageot
Copy link
Contributor Author

dgageot commented Jan 11, 2019

Oh, I forgot windows...

@codecov-io
Copy link

codecov-io commented Jan 21, 2019

Codecov Report

Merging #1451 into master will increase coverage by 0.28%.
The diff coverage is 26.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1451      +/-   ##
=========================================
+ Coverage   45.62%   45.9%   +0.28%     
=========================================
  Files         116     116              
  Lines        4870    4862       -8     
=========================================
+ Hits         2222    2232      +10     
+ Misses       2424    2410      -14     
+ Partials      224     220       -4
Impacted Files Coverage Δ
pkg/skaffold/deploy/kubectl/cli.go 0% <0%> (ø) ⬆️
pkg/skaffold/deploy/kubectl/manifests.go 44.44% <100%> (+23.61%) ⬆️
pkg/skaffold/deploy/kubectl.go 77.61% <80%> (+25.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3084ca3...6a7e58d. Read the comment docs.

@dgageot dgageot added the wip label Jan 21, 2019
@dgageot dgageot force-pushed the kubectl-create branch 2 times, most recently from 5fdb7f8 to cda4f74 Compare January 22, 2019 11:46
@dgageot dgageot removed the wip label Jan 22, 2019
@dgageot dgageot force-pushed the kubectl-create branch 5 times, most recently from 11889f4 to 113cac6 Compare January 24, 2019 05:42
@dgageot dgageot force-pushed the kubectl-create branch 5 times, most recently from 5e903db to ba8ca7e Compare January 28, 2019 05:49
@dgageot dgageot added kokoro:run runs the kokoro jobs on a PR and removed kokoro:run runs the kokoro jobs on a PR labels Jan 28, 2019
 + Adds support for json manifests
 + Should help when kustomize is built into kubectl

Fixes GoogleContainerTools#921

Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants