-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use kubectl to read the manifests #1451
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oh, I forgot windows... |
127d32e
to
b606c83
Compare
b606c83
to
d5f6f3b
Compare
Codecov Report
@@ Coverage Diff @@
## master #1451 +/- ##
=========================================
+ Coverage 45.62% 45.9% +0.28%
=========================================
Files 116 116
Lines 4870 4862 -8
=========================================
+ Hits 2222 2232 +10
+ Misses 2424 2410 -14
+ Partials 224 220 -4
Continue to review full report at Codecov.
|
5fdb7f8
to
cda4f74
Compare
11889f4
to
113cac6
Compare
5e903db
to
ba8ca7e
Compare
+ Adds support for json manifests + Should help when kustomize is built into kubectl Fixes GoogleContainerTools#921 Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
ba8ca7e
to
6a7e58d
Compare
balopat
approved these changes
Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #921
Signed-off-by: David Gageot david@gageot.net