Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Rename kustomize.KustomizePath to kustomize.Path" #1061

Merged

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Sep 28, 2018

This needs to be reverted because it was not merged in time into the new v1alpha3 config format.

This reverts commit ceeb247.

Signed-off-by: David Gageot <david@gageot.net>
@codecov-io
Copy link

codecov-io commented Sep 28, 2018

Codecov Report

Merging #1061 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1061   +/-   ##
=======================================
  Coverage   40.85%   40.85%           
=======================================
  Files          70       70           
  Lines        3084     3084           
=======================================
  Hits         1260     1260           
  Misses       1699     1699           
  Partials      125      125
Impacted Files Coverage Δ
pkg/skaffold/deploy/kustomize.go 36.23% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a91383d...cb9b618. Read the comment docs.

Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@balopat balopat merged commit 361e95c into GoogleContainerTools:master Sep 28, 2018
@dgageot dgageot deleted the revert-kustomize-path-rename branch December 28, 2018 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants