Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kaniko improvements #1101

Merged
merged 5 commits into from
Oct 5, 2018
Merged

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Oct 5, 2018

  • Add more logs to better debug when it goes weird
  • Auto detect the bucket name from the image names if no bucket is provided
  • Let the user override the kaniko image
  • Upgrade kaniko to 0.4.0
  • Simplify the code

Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot force-pushed the kaniko-improvements branch from 7eeadf4 to b0df629 Compare October 5, 2018 08:22
@codecov-io
Copy link

Codecov Report

Merging #1101 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1101   +/-   ##
=======================================
  Coverage   43.16%   43.16%           
=======================================
  Files          74       74           
  Lines        3408     3408           
=======================================
  Hits         1471     1471           
  Misses       1799     1799           
  Partials      138      138
Impacted Files Coverage Δ
pkg/skaffold/docker/context.go 31.03% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d65ab29...b0df629. Read the comment docs.

@dgageot dgageot merged commit d5853d4 into GoogleContainerTools:master Oct 5, 2018
@dgageot dgageot deleted the kaniko-improvements branch December 28, 2018 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants