Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding deprecation policy and document component stability #1324

Merged
merged 4 commits into from
Nov 29, 2018

Conversation

balopat
Copy link
Contributor

@balopat balopat commented Nov 27, 2018

Closes #1263.

@codecov-io
Copy link

codecov-io commented Nov 27, 2018

Codecov Report

Merging #1324 into master will decrease coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1324      +/-   ##
==========================================
- Coverage   45.04%   44.84%   -0.21%     
==========================================
  Files         107      110       +3     
  Lines        4740     4797      +57     
==========================================
+ Hits         2135     2151      +16     
- Misses       2384     2425      +41     
  Partials      221      221
Impacted Files Coverage Δ
pkg/skaffold/runner/runner.go 53.7% <0%> (-3.71%) ⬇️
cmd/skaffold/app/cmd/deploy.go 0% <0%> (ø) ⬆️
pkg/skaffold/config/options.go 88.23% <0%> (ø) ⬆️
pkg/skaffold/build/sequence.go 0% <0%> (ø)
pkg/skaffold/build/parallel.go 0% <0%> (ø)
pkg/skaffold/build/prebuilt.go 82.75% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c2e4bb...1291e10. Read the comment docs.

Copy link
Contributor

@dgageot dgageot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with a few nits


The pipeline config, i.e. `skaffold.yaml` is **beta**.

This means that you can safely depend on the skaffold config with the assumption that skaffold will autoupgrade to the latest version:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

autoupgrade or auto-upgrade?


## Skaffold components

We are committed to design for autoupgradeable changes in the config.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

autoupgradeable or auto-upgradeable?

@balopat balopat merged commit 11d6738 into GoogleContainerTools:master Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants