Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new skaffold site #1338

Merged
merged 23 commits into from
Dec 10, 2018
Merged

new skaffold site #1338

merged 23 commits into from
Dec 10, 2018

Conversation

balopat
Copy link
Contributor

@balopat balopat commented Nov 29, 2018

Skaffold site is living currently on the skaffold_site feature branch for collaboration.

This PR is tracking the latest version of the docs and makes sure there are no merge conflicts with master.

To contribute changes to the site, raise a PR against the skaffold_site base, then after the change is merged, add the docs-modification label to this PR and our bot should deploy a preview version that will be accessible through an ephemeral URL.


Fixes #629.
Fixes #628.
Fixes #498.
Fixes #227.
Fixes #1076 .
Fixes #519.
Fixes #1327.

TODO:

[X] a release script
[X] a PR review workflow (netlify or something similar)
[X ] a front page (and a new theme)

Adds the foundations of the new site based on hugo and Google's docsy template with local preview in docker and release job definitions from master and tag pushes that deploy to our Firebase sites. 
At the same time removes the current asciidocs based documentation.
@balopat balopat changed the title new skaffold site (#1060) new skaffold site Nov 29, 2018
@balopat balopat added the docs-modifications runs the docs preview service on the given PR label Nov 29, 2018
@container-tools-bot
Copy link

Please visit http://35.236.7.76:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Nov 29, 2018
@codecov-io
Copy link

codecov-io commented Nov 29, 2018

Codecov Report

Merging #1338 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1338      +/-   ##
=========================================
- Coverage   44.42%   44.4%   -0.02%     
=========================================
  Files         109     109              
  Lines        4540    4542       +2     
=========================================
  Hits         2017    2017              
- Misses       2317    2319       +2     
  Partials      206     206
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/cmd.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e46beef...a4e4c86. Read the comment docs.

@dgageot
Copy link
Contributor

dgageot commented Nov 30, 2018

@balopat Can it be merged? I'd find it much easier to contribute fixes an improvements.

@balopat balopat added the docs-modifications runs the docs preview service on the given PR label Dec 9, 2018
@container-tools-bot
Copy link

Error creating deployment docs-controller-deployment-1338, please visit https://storage.googleapis.com/webhook-logs/logs-1338-1544380790402794631 to view logs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Dec 9, 2018
@balopat balopat added the docs-modifications runs the docs preview service on the given PR label Dec 9, 2018
@container-tools-bot
Copy link

Error creating deployment docs-controller-deployment-1338, please visit https://storage.googleapis.com/webhook-logs/logs-1338-1544386170419491143 to view logs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Dec 9, 2018
@balopat balopat added the docs-modifications runs the docs preview service on the given PR label Dec 9, 2018
@container-tools-bot
Copy link

Please visit http://35.236.74.153:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Dec 9, 2018
@balopat balopat added the docs-modifications runs the docs preview service on the given PR label Dec 10, 2018
@balopat
Copy link
Contributor Author

balopat commented Dec 10, 2018

@dgageot PTAL I'd be okay with merging now even though it's far from perfect, but it's better than what we have, yay :)

@container-tools-bot
Copy link

Please visit http://35.236.7.76:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Dec 10, 2018
@balopat balopat added the docs-modifications runs the docs preview service on the given PR label Dec 10, 2018
@container-tools-bot
Copy link

Please visit http://35.236.74.153:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Dec 10, 2018
@balopat balopat added the docs-modifications runs the docs preview service on the given PR label Dec 10, 2018
@container-tools-bot
Copy link

Please visit http://35.236.7.76:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Dec 10, 2018
@balopat balopat added the docs-modifications runs the docs preview service on the given PR label Dec 10, 2018
@container-tools-bot
Copy link

Please visit http://35.236.74.153:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Dec 10, 2018
@dgageot
Copy link
Contributor

dgageot commented Dec 10, 2018

🎉 💃

@dgageot dgageot merged commit fb09e0e into master Dec 10, 2018
@hypnoglow
Copy link
Contributor

Hi @balopat

Any reason Gopkg.lock was reverted from dep 0.5.* format to dep 0.4.* format?

@dgageot dgageot deleted the skaffold_site branch January 26, 2019 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants