-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new skaffold site #1338
new skaffold site #1338
Conversation
Adds the foundations of the new site based on hugo and Google's docsy template with local preview in docker and release job definitions from master and tag pushes that deploy to our Firebase sites. At the same time removes the current asciidocs based documentation.
Please visit http://35.236.7.76:1313 to view changes to the docs. |
Codecov Report
@@ Coverage Diff @@
## master #1338 +/- ##
=========================================
- Coverage 44.42% 44.4% -0.02%
=========================================
Files 109 109
Lines 4540 4542 +2
=========================================
Hits 2017 2017
- Misses 2317 2319 +2
Partials 206 206
Continue to review full report at Codecov.
|
@balopat Can it be merged? I'd find it much easier to contribute fixes an improvements. |
Error creating deployment docs-controller-deployment-1338, please visit https://storage.googleapis.com/webhook-logs/logs-1338-1544380790402794631 to view logs. |
Error creating deployment docs-controller-deployment-1338, please visit https://storage.googleapis.com/webhook-logs/logs-1338-1544386170419491143 to view logs. |
Please visit http://35.236.74.153:1313 to view changes to the docs. |
0e0da93
to
76e67d5
Compare
@dgageot PTAL I'd be okay with merging now even though it's far from perfect, but it's better than what we have, yay :) |
Please visit http://35.236.7.76:1313 to view changes to the docs. |
Please visit http://35.236.74.153:1313 to view changes to the docs. |
Please visit http://35.236.7.76:1313 to view changes to the docs. |
Please visit http://35.236.74.153:1313 to view changes to the docs. |
🎉 💃 |
Hi @balopat Any reason |
Skaffold site is living currently on the
skaffold_site
feature branch for collaboration.This PR is tracking the latest version of the docs and makes sure there are no merge conflicts with master.
To contribute changes to the site, raise a PR against the
skaffold_site
base, then after the change is merged, add thedocs-modification
label to this PR and our bot should deploy a preview version that will be accessible through an ephemeral URL.Fixes #629.
Fixes #628.
Fixes #498.
Fixes #227.
Fixes #1076 .
Fixes #519.
Fixes #1327.
TODO:
[X] a release script
[X] a PR review workflow (netlify or something similar)
[X ] a front page (and a new theme)