Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes to kaniko builder #1461

Merged
merged 1 commit into from
Jan 14, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jan 14, 2019

Signed-off-by: David Gageot david@gageot.net

Signed-off-by: David Gageot <david@gageot.net>
@@ -54,7 +54,7 @@ const (
DefaultKanikoEmptyDirName = "kaniko-emptydir"
DefaultKanikoEmptyDirMountPath = "/kaniko/buildcontext"

DefaultAlpineImage = "alpine"
DefaultBusyboxImage = "busybox"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

every bit counts :)

@codecov-io
Copy link

codecov-io commented Jan 14, 2019

Codecov Report

Merging #1461 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1461      +/-   ##
==========================================
- Coverage   44.46%   44.45%   -0.01%     
==========================================
  Files         112      112              
  Lines        4642     4643       +1     
==========================================
  Hits         2064     2064              
- Misses       2371     2372       +1     
  Partials      207      207
Impacted Files Coverage Δ
pkg/skaffold/build/kaniko/run.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6972c5f...e25041c. Read the comment docs.

@dgageot dgageot merged commit d23064a into GoogleContainerTools:master Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants