Enhance hack/check-samples script #1858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejal29
requested review from
balopat,
dgageot,
nkubala,
priyawadhwa and
r2d4
as code owners
tejal29
force-pushed
the
enhance_hack_script
branch
3 times, most recently
from
41b6fc3 to
7f59f2f
Compare
Some of the files in the examples directory could be ignored by git e.g. integration/examples/jib-multimodule/target if developers .gitconfig ignore target dir everywhere. Since this script does a file comparison, debugging failures in such situation takes times. Co-authored-by: Balint Pato <balopat@users.noreply.github.com>
tejal29
force-pushed
the
enhance_hack_script
branch
from
7f59f2f to
183125a
Compare
balopat
approved these changes
Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Some of the files in the examples directory could be ignored by
git e.g. integration/examples/jib-multimodule/target if developers
.gitconfig ignore target dir everywhere.
Since this script does a file comparison, debugging failures in such
situation takes times.
To verify on this branch run: