Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SkaffoldPipeline to SkaffoldConfig #2015

Merged
merged 1 commit into from
Apr 24, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Apr 24, 2019

Fixes #2005

Signed-off-by: David Gageot david@gageot.net

Fixes GoogleContainerTools#2005

Signed-off-by: David Gageot <david@gageot.net>
@codecov-io
Copy link

Codecov Report

Merging #2015 into master will not change coverage.
The diff coverage is 96.72%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2015   +/-   ##
=======================================
  Coverage   55.49%   55.49%           
=======================================
  Files         173      173           
  Lines        7512     7512           
=======================================
  Hits         4169     4169           
  Misses       2952     2952           
  Partials      391      391
Impacted Files Coverage Δ
pkg/skaffold/schema/versions.go 74.35% <ø> (ø) ⬆️
pkg/skaffold/initializer/init.go 21.6% <0%> (ø) ⬆️
pkg/skaffold/schema/v1beta7/config.go 100% <100%> (ø) ⬆️
pkg/skaffold/schema/v1beta1/config.go 100% <100%> (ø) ⬆️
pkg/skaffold/schema/v1beta5/upgrade.go 100% <100%> (ø) ⬆️
pkg/skaffold/schema/v1beta5/config.go 100% <100%> (ø) ⬆️
pkg/skaffold/schema/v1beta6/config.go 100% <100%> (ø) ⬆️
pkg/skaffold/schema/v1alpha3/config.go 100% <100%> (ø) ⬆️
pkg/skaffold/schema/v1alpha5/config.go 100% <100%> (ø) ⬆️
pkg/skaffold/schema/v1beta3/config.go 100% <100%> (ø) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a756680...7318c86. Read the comment docs.

@nkubala nkubala merged commit 3d87a2a into GoogleContainerTools:master Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1beta8 broke schema validation in Cloud Code for VSCode
4 participants