Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add github pull request template #2894

Merged
merged 2 commits into from
Sep 20, 2019
Merged

add github pull request template #2894

merged 2 commits into from
Sep 20, 2019

Conversation

tejal29
Copy link
Contributor

@tejal29 tejal29 commented Sep 16, 2019

Description

This PR adds a github pull request template.
An example PR is tejal29#3

@codecov
Copy link

codecov bot commented Sep 16, 2019 •
edited
Loading

Codecov Report

Merging #2894 into master will not change coverage.
The diff coverage is n/a.

balopat
balopat suggested changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you so much for putting this together! I added some comments!

@tejal29 tejal29 closed this Sep 18, 2019
@tejal29 tejal29 reopened this Sep 18, 2019
@balopat balopat merged commit bd8b396 into GoogleContainerTools:master Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@dgageot dgageot Awaiting requested review from dgageot

@nkubala nkubala Awaiting requested review from nkubala

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tejal29 @balopat @googlebot