Improve error messages for deploy.kubeContext error cases
#2993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
Also, fix config version of the profiles example. Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
Before, the error did not specify which profiles were activated and what is the initial or effective kube-context. Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
corneliusweig
requested review from
balopat,
dgageot,
nkubala,
priyawadhwa and
tejal29
as code owners
|
cc @balopat as you raised this in #2510 (review). |
Codecov Report
|
tejal29
suggested changes
Oct 7, 2019
| } | ||
|
|
||
| func activatedProfiles(profiles []latest.Profile, opts cfg.SkaffoldOptions) ([]string, bool, error) { | ||
| func activatedProfiles(profiles []latest.Profile, opts cfg.SkaffoldOptions) ([]string, []string, error) { |
There was a problem hiding this comment.
this now returns a list of profiles and activated profile?
There was a problem hiding this comment.
Not quite. It returns a list of activated profiles and a list of activated profiles that are kube-context specific. I added a godoc to clarify this.
Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
|
@tejal29 Thanks taking the time to look at this! At your convenience please take another look. |
Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
tejal29
approved these changes
Oct 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #2510 (review)
Description
Improve error logging for two error cases which may happen when configuring the kube-context via
skaffold.yamlIn addition, include the newly added
example/profilesin integration tests (I assumed that all examples are automatically tested, but this is not the case).User facing changes
after When changing
deploy.kubeContextof a running Skaffold process, a warn-level log message is printed, sayingbefore When trying to activate conflicting Skaffold profiles, there used to be an error with the message
after This log message was improved to include some more information about the initial and resulting kube-context, and what are the context-specific profiles which got activated by the initial kube-context, e.g.:
Next PRs.
n/a
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes