-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a resourceCounter to track pods #3016
Conversation
Codecov Report
|
Co-Authored-By: Balint Pato <balopat@users.noreply.github.com>
@@ -220,9 +225,34 @@ func newCounter(i int) *counter { | |||
} | |||
} | |||
|
|||
func (c *counter) markProcessed(err error) int { | |||
func (c *counter) markProcessed(err error) counter { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you think about moving all these instance methods instead into functions, like the style of append
?
func markProcessed(c *counter, err error) counter
? that will emphasize it even more that these are not state mutations.
Relates to #176
Description
In this PR add a
resourceCounter
which trackspods
anddeployments
pods
counter is initialized to 0 and used anywhere.User facing changes
n/a
Next PRs.
getDeployStatus
andprintResourceStatus
to use theresourceCounter.pod
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
examples
dir, please copy them tointegration/examples
integration/examples
dir, should be tested in integration testReviewer Notes
Release Notes