Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add links to docs which are present #3026

Merged
merged 3 commits into from
Oct 10, 2019

Conversation

tejal29
Copy link
Contributor

@tejal29 tejal29 commented Oct 9, 2019

Relates to #3023

Description
In this change, we add a feature matrix and links to features which are documented.

User facing changes

please review "docs/references/deprecation/" the url generated by docs preview service.

Next PRs.
n/a

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Mentions any output changes.
  • Adds documentation as needed: user docs, YAML reference, CLI reference.
  • Adds integration tests if needed.

Reviewer Notes

  • The code flow looks good.
  • Unit test added.
  • User facing changes look good.

Release Notes

@tejal29 tejal29 added meta/docs-preview docs-modifications runs the docs preview service on the given PR and removed meta/docs-preview labels Oct 9, 2019
@container-tools-bot
Copy link

Error creating deployment docs-controller-deployment-3026, please visit https://storage.googleapis.com/webhook-logs/logs-3026-1570659915251075315 to view logs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Oct 9, 2019
@codecov
Copy link

codecov bot commented Oct 9, 2019

Codecov Report

Merging #3026 into master will not change coverage.
The diff coverage is n/a.

@tejal29 tejal29 mentioned this pull request Oct 9, 2019
8 tasks
@tejal29 tejal29 added the docs-modifications runs the docs preview service on the given PR label Oct 9, 2019
@container-tools-bot
Copy link

Please visit http://35.236.103.231:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Oct 9, 2019
@balopat balopat merged commit c8afc71 into GoogleContainerTools:master Oct 10, 2019
- version: beta


## Exceptions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should have not removed the exceptions.

@tejal29 tejal29 deleted the feature-matric branch April 15, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants