Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify custom builder example #3183

Merged
merged 1 commit into from
Nov 6, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Nov 6, 2019

  • Simplify build.sh script
  • Rely on defaults in skaffold.yaml
  • Use $IMAGE instead of $IMAGES in the doc
  • minor other things

Signed-off-by: David Gageot david@gageot.net

Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot force-pushed the improve-custom-sample branch from 709e3ac to 8de366f Compare November 6, 2019 11:18
@codecov
Copy link

codecov bot commented Nov 6, 2019

Codecov Report

Merging #3183 into master will not change coverage.
The diff coverage is n/a.

@balopat balopat merged commit 6feb3a3 into GoogleContainerTools:master Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants