Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change SyncMap supported types check style #3328

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Conversation

loosebazooka
Copy link
Member

Allow for future extension with more supported builders like
jib, which is expected to produce a syncMap

Just trying to get used to the skaffold code and go things with small PRs.

Allow for future extension with more supported builders like
jib, which is expected to produce a syncMap
@codecov
Copy link

codecov bot commented Dec 3, 2019

Codecov Report

Merging #3328 into master will not change coverage.
The diff coverage is 0%.

Impacted Files Coverage Δ
pkg/skaffold/build/local/local.go 43.63% <0%> (ø) ⬆️

@balopat balopat added the pr/lgtm label Dec 3, 2019
@balopat
Copy link
Contributor

balopat commented Dec 3, 2019

unrelated error:

--- FAIL: TestBuildKanikoInsecureRegistry (49.56s)
    build_test.go:374: skaffold build: exit status 1, Generating tags...
         - kaniko-insecure -> 34.70.129.71:5000/kaniko-insecure:v1.0.0-124-gceb1a88
        Checking cache...
         - kaniko-insecure: Not found. Building
        Creating kaniko secret [default/e2esecret]...
        Building [kaniko-insecure]...
        Storing build context at /tmp/context-06fa688fd5a564d4c05a6136236a8f8c.tar.gz
    panic.go:406: time="2019-12-02T23:58:37Z" level=fatal msg="build failed: build failed: building [kaniko-insecure]: kaniko build for [kaniko-insecure]: waiting for pod to complete: condition error: pod already in terminal phase: Failed"

@balopat balopat merged commit a6732ff into master Dec 3, 2019
@chanseokoh chanseokoh deleted the change-order-syncmap branch December 4, 2019 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants