Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ko sample #3805

Merged
merged 1 commit into from
Mar 10, 2020
Merged

Fix ko sample #3805

merged 1 commit into from
Mar 10, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Mar 10, 2020

The previous code used to modify the artifact’s go.mod file

Signed-off-by: David Gageot david@gageot.net

@codecov
Copy link

codecov bot commented Mar 10, 2020 •
edited
Loading

Codecov Report

Merging #3805 into master will not change coverage.
The diff coverage is n/a.

@dgageot
Fix ko sample
44deff6 
The previous code used to modify the artifact’s
go.mod file

Signed-off-by: David Gageot <david@gageot.net>
@dgageot
Copy link
Contributor Author

dgageot commented Mar 10, 2020

Self merging small fix to ko samples

@dgageot dgageot merged commit 5ef736b into GoogleContainerTools:master Mar 10, 2020
@fmotrifork fmotrifork mentioned this pull request Mar 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat Awaiting requested review from balopat

@nkubala nkubala Awaiting requested review from nkubala

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgageot @googlebot