Initial prototype for pod health check hook up #4223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For me when I have the wrong image in the pod spec "waiting to start, image can't be pulled" is not appearing just "creating container xyz": And then it times out. |
tejal29
requested review from
balopat,
briandealwis,
dgageot,
nkubala and
tstromberg
as code owners
Sorry, just saw this now. I was able to see the error you mentioned, Let me rebase this branch from master and report back. |
Codecov Report
|
|
@balopat the commit 139bef9 ensures deployments status changed when pod statuses change. |
This was referenced Jun 1, 2020
briandealwis
approved these changes
Jun 5, 2020
There was a problem hiding this comment.
Gave it a try with the cloud-code-samples, and although I think we can tweak some things, it's looking good!
Waiting for deployments to stabilize...
- deployment/java-guestbook-backend: waiting for rollout to finish: 0 of 1 updated replicas are available...
- pod/java-guestbook-backend-5df8f495b-tcql8: container init-db-ready in error:
- deployment/java-guestbook-frontend: waiting for rollout to finish: 0 of 1 updated replicas are available...
- pod/java-guestbook-frontend-ffd5d6495-fkmq9: creating container frontend
- deployment/java-guestbook-mongodb: waiting for rollout to finish: 0 of 1 updated replicas are available...
- pod/java-guestbook-mongodb-868948f9bb-gbbzp: creating container mongo
- deployment/java-guestbook-frontend is ready. [2/3 deployment(s) still pending]
- deployment/java-guestbook-mongodb is ready. [1/3 deployment(s) still pending]
- deployment/java-guestbook-backend: waiting for rollout to finish: 0 of 1 updated replicas are available...
- pod/java-guestbook-backend-5df8f495b-tcql8: container init-db-ready terminated with exit code 0
- deployment/java-guestbook-backend is ready.
Deployments stabilized in 31.796627999s
| @@ -105,12 +105,12 @@ func (d *Deployment) CheckStatus(ctx context.Context, runCtx *runcontext.RunCont | |||
| } | |||
|
|
|||
| details := d.cleanupStatus(string(b)) | |||
| d.UpdateStatus(details, err) | |||
|
|
|||
| err = parseKubectlRolloutError(err) | |||
| if err == errKubectlKilled { | |||
| err = fmt.Errorf("received Ctrl-C or deployments could not stabilize within %v: %w", d.deadline, err) | |||
There was a problem hiding this comment.
It would be nice to be able to separate these conditions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #nnn
Related: Relevant tracking issues, for context
Merge before/after: Dependent or prerequisite PRs
Description
This is first iteration of hooking up pod health check with skaffold. With this change,
depoyment.CheckStatuswill query for pods using the label defined indeployment.Template.Labels.deployment.LastReportedStatuswill now print deployment and pod statuses.Some of these changes are already broken in smaller PR
diagimprovements #4219Still a couple of opportunities to make this smaller. ( will follow up)
Please review them the output.
User facing changes (remove if N/A)
yes.
Add event stream!
Follow-up Work (remove if N/A)