Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify 'survey' command text #4625

Merged
merged 2 commits into from
Aug 4, 2020
Merged

Clarify 'survey' command text #4625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ea7ea8
Clarify 'survey' command text
tstromberg Aug 4, 2020
6a016f0
Update markdown docs via hack/generate-man.sh
tstromberg Aug 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/skaffold/app/cmd/survey.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import (

func NewCmdSurvey() *cobra.Command {
return NewCmd("survey").
WithDescription("Show Skaffold survey url").
WithDescription("Opens a web browser to fill out the Skaffold survey").
NoArgs(showSurvey)
}

Expand Down
4 changes: 2 additions & 2 deletions docs/content/en/docs/references/cli/_index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ Other Commands:
credits Export third party notices to given path (./skaffold-credits by default)
diagnose Run a diagnostic on Skaffold
schema List and print json schemas used to validate skaffold.yaml configuration
survey Show Skaffold survey url
survey Opens a web browser to fill out the Skaffold survey
version Print the version information

Use "skaffold <command> --help" for more information about a given command.
Expand Down Expand Up @@ -930,7 +930,7 @@ Env vars:

### skaffold survey

Show Skaffold survey url
Opens a web browser to fill out the Skaffold survey

```

Expand Down
7 changes: 5 additions & 2 deletions pkg/skaffold/survey/survey.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,12 @@ const (

var (
Form = fmt.Sprintf(`Thank you for offering your feedback on Skaffold! Understanding your experiences and opinions helps us make Skaffold better for you and other users.
Our survey can be found here: %s

To permanently disable the survey prompt, run:
Skaffold will now attempt to open the survey in your default web browser. You may also manually open it using this link:

%s

Tip: To permanently disable the survey prompt, run:
skaffold config set --survey --global disable-prompt true`, URL)

// for testing
Expand Down