Support multi-level repos for Artifact Registry #5053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Description** This change adds Artifact Registry (AR) as another special case for [image name rewriting](https://skaffold.dev/docs/environment/image-registries/), similar to Container Registry (GCR). Both GCR and AR support arbitrarily deep image repo names. This change looks for `gcr.io` or `-docker.pkg.dev` in the registry domain. **Related**: #4878 **User facing changes** Updates to documentation on image name rewriting.
Codecov Report
@@ Coverage Diff @@
## master #5053 +/- ##
==========================================
+ Coverage 72.26% 72.28% +0.01%
==========================================
Files 368 368
Lines 12912 12927 +15
==========================================
+ Hits 9331 9344 +13
- Misses 2890 2891 +1
- Partials 691 692 +1
Continue to review full report at Codecov.
|
Use regex to match Google Cloud project ID. Co-authored-by: Brian de Alwis <bsd@acm.org>
briandealwis
approved these changes
Nov 26, 2020
This was referenced Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds Artifact Registry (AR) as another special case for image name rewriting, similar to Container Registry (GCR).
Both GCR and AR support arbitrarily deep image repo names. This change looks for
gcr.ioor-docker.pkg.devin the registry domain.Related: #4878
User facing changes
Updates to documentation on image name rewriting.