Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhide XXenableManifestGeneration for skaffold init, remove unnecessary print line #5152

Conversation

MarlonGamez
Copy link
Contributor

@MarlonGamez MarlonGamez commented Dec 15, 2020

Description
This PR unhides and renames the flag for manifest generation when using skaffold init. It's been changed from --XXenableManifestGeneration to --generate-manifests. I think this feature is at a point where we can put it into the hands of the user and try to get some feedback on it.

I've also removed an unnecessary line that is being printed in some cases when running init. I don't think it provides any value to the user. Please let me know if you think we should keep it there.

There's also a small fix to validation function that validates user input for port forwarding info.

User facing changes (remove if N/A)
Users will now see the option if they run skaffold init --help

@google-cla google-cla bot added the cla: yes label Dec 15, 2020
@MarlonGamez MarlonGamez force-pushed the unhide-manifest-generation branch from 477218a to 4bf6d1b Compare December 15, 2020 18:18
@codecov
Copy link

codecov bot commented Dec 15, 2020

Codecov Report

Merging #5152 (7e4a9bb) into master (6dbe2d2) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5152      +/-   ##
==========================================
- Coverage   72.35%   72.32%   -0.04%     
==========================================
  Files         382      382              
  Lines       13589    13588       -1     
==========================================
- Hits         9832     9827       -5     
- Misses       3038     3040       +2     
- Partials      719      721       +2     
Impacted Files Coverage Δ
pkg/skaffold/initializer/build/util.go 100.00% <ø> (ø)
pkg/skaffold/initializer/prompt/prompt.go 66.66% <0.00%> (ø)
cmd/skaffold/app/cmd/init.go 100.00% <100.00%> (ø)
pkg/skaffold/util/tar.go 50.66% <0.00%> (-5.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dbe2d2...7e4a9bb. Read the comment docs.

@MarlonGamez MarlonGamez marked this pull request as ready for review December 15, 2020 18:36
@MarlonGamez MarlonGamez requested a review from a team as a code owner December 15, 2020 18:36
@MarlonGamez MarlonGamez requested a review from tejal29 December 15, 2020 18:36
@MarlonGamez MarlonGamez force-pushed the unhide-manifest-generation branch from 4bf6d1b to 7e4a9bb Compare December 15, 2020 18:41
@MarlonGamez MarlonGamez merged commit 7247f4e into GoogleContainerTools:master Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants