Unhide XXenableManifestGeneration for skaffold init, remove unnecessary print line #5152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR unhides and renames the flag for manifest generation when using
skaffold init
. It's been changed from--XXenableManifestGeneration
to--generate-manifests
. I think this feature is at a point where we can put it into the hands of the user and try to get some feedback on it.I've also removed an unnecessary line that is being printed in some cases when running init. I don't think it provides any value to the user. Please let me know if you think we should keep it there.
There's also a small fix to validation function that validates user input for port forwarding info.
User facing changes (remove if N/A)
Users will now see the option if they run
skaffold init --help