Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jib to 2.7.1 #5223

Merged
merged 2 commits into from
Jan 13, 2021
Merged

Update jib to 2.7.1 #5223

merged 2 commits into from
Jan 13, 2021

Conversation

loosebazooka
Copy link
Member

Update examples and testdata for latest jib release.

@chanseokoh
Copy link
Member

FYI #5119 (comment)

But should be OK.

@loosebazooka
Copy link
Member Author

I vaguely recall some comment to the contrary, but I'll just follow the latest comment just to be sure... I'll undo the changes in examples.

@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #5223 (acb0a7a) into master (95092ad) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5223      +/-   ##
==========================================
+ Coverage   71.84%   71.87%   +0.02%     
==========================================
  Files         387      387              
  Lines       13974    13974              
==========================================
+ Hits        10040    10044       +4     
+ Misses       3195     3193       -2     
+ Partials      739      737       -2     
Impacted Files Coverage Δ
pkg/skaffold/util/tar.go 56.00% <0.00%> (+5.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95092ad...acb0a7a. Read the comment docs.

Copy link
Member

@briandealwis briandealwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@briandealwis briandealwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can change the examples too since they shouldn't cause break the latest version of Skaffold.

@briandealwis
Copy link
Member

Just read @tejal29's comment. Will bring it up for discussion.

@briandealwis briandealwis merged commit 2efeb55 into master Jan 13, 2021
@chanseokoh chanseokoh deleted the update-jib-2.7.1 branch February 25, 2021 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants