Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

track the platform type at the launch level #5353

Merged
merged 1 commit into from
Feb 4, 2021

Conversation

IsaacPD
Copy link
Contributor

@IsaacPD IsaacPD commented Feb 4, 2021

Fixes: #5352

Description
Add label to launch metric that describes the platform type that is being used. With this there are only 3 more labels that can be added to the launches metric.

@IsaacPD IsaacPD requested a review from a team as a code owner February 4, 2021 20:44
@google-cla google-cla bot added the cla: yes label Feb 4, 2021
@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #5353 (17da5c7) into master (719d74f) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5353      +/-   ##
==========================================
+ Coverage   71.80%   71.83%   +0.03%     
==========================================
  Files         392      392              
  Lines       14228    14229       +1     
==========================================
+ Hits        10217    10222       +5     
+ Misses       3259     3257       -2     
+ Partials      752      750       -2     
Impacted Files Coverage Δ
pkg/skaffold/instrumentation/types.go 0.00% <ø> (ø)
pkg/skaffold/instrumentation/export.go 76.56% <100.00%> (+0.18%) ⬆️
pkg/skaffold/util/tar.go 56.00% <0.00%> (+5.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 719d74f...17da5c7. Read the comment docs.

Copy link
Member

@briandealwis briandealwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IsaacPD IsaacPD merged commit 8159a13 into GoogleContainerTools:master Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export the platform type in skaffold metrics
2 participants