Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metric for the count of skaffold configurations in current session; fix the build platform type metric to save list of all platforms #5437

Merged
merged 2 commits into from
Feb 23, 2021

Conversation

gsquared94
Copy link
Contributor

Fixes #5329

…n; fix the build platform type metric to save list of all platforms
@gsquared94 gsquared94 requested a review from a team as a code owner February 22, 2021 20:49
@google-cla google-cla bot added the cla: yes label Feb 22, 2021
@codecov
Copy link

codecov bot commented Feb 22, 2021

Codecov Report

Merging #5437 (1c84d3c) into master (1a93be5) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5437      +/-   ##
==========================================
- Coverage   71.40%   71.38%   -0.02%     
==========================================
  Files         397      397              
  Lines       14543    14549       +6     
==========================================
+ Hits        10384    10386       +2     
- Misses       3388     3390       +2     
- Partials      771      773       +2     
Impacted Files Coverage Δ
pkg/skaffold/instrumentation/types.go 0.00% <ø> (ø)
pkg/skaffold/instrumentation/export.go 76.92% <100.00%> (+0.17%) ⬆️
pkg/skaffold/instrumentation/meter.go 58.06% <100.00%> (+8.06%) ⬆️
pkg/skaffold/util/tar.go 50.66% <0.00%> (-5.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a93be5...1c84d3c. Read the comment docs.

Copy link
Contributor

@MarlonGamez MarlonGamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarlonGamez MarlonGamez merged commit 7f2eeed into GoogleContainerTools:master Feb 23, 2021
@gsquared94 gsquared94 added this to the v1.21.0 milestone Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add metric for feature usage
2 participants