Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Argo Rollout resource manifests to be transformed (#5523) #5524

Merged

Conversation

flxbk
Copy link
Contributor

@flxbk flxbk commented Mar 10, 2021

Fixes: #5523

Description

This PR adds the resource kind Rollout in the group argoproj.io to the transformableAllowList to allow the manifest visitor to transform fields on such resources.

@flxbk flxbk requested a review from a team as a code owner March 10, 2021 17:17
@google-cla
Copy link

google-cla bot commented Mar 10, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@flxbk flxbk force-pushed the transform-argo-rollouts branch from f3d7cec to 51b7654 Compare March 10, 2021 17:24
@google-cla google-cla bot added cla: yes and removed cla: no labels Mar 10, 2021
@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #5524 (51b7654) into master (802ef8a) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5524      +/-   ##
==========================================
- Coverage   71.70%   71.68%   -0.03%     
==========================================
  Files         399      399              
  Lines       14750    14750              
==========================================
- Hits        10577    10574       -3     
- Misses       3398     3399       +1     
- Partials      775      777       +2     
Impacted Files Coverage Δ
pkg/skaffold/kubernetes/manifest/visitor.go 95.00% <ø> (ø)
pkg/skaffold/docker/image.go 78.13% <0.00%> (-1.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 802ef8a...51b7654. Read the comment docs.

@gsquared94 gsquared94 added the kokoro:force-run forces a kokoro re-run on a PR label Mar 10, 2021
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Mar 10, 2021
@gsquared94 gsquared94 merged commit 2added6 into GoogleContainerTools:master Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transform Argo Rollout manifests
3 participants