Remove unwanted value recorded. #5555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While doing Code walks, @IsaacPD mentioned, both "flag_value" and "value" are duplicates and used for recording flag value ``` label.String("flag_value", v), label.String("command", meter.Command), label.String("value", v), ``` Removing "value" in favor of the other.
Codecov Report
@@ Coverage Diff @@
## master #5555 +/- ##
==========================================
+ Coverage 71.26% 71.27% +0.01%
==========================================
Files 400 400
Lines 14976 14975 -1
==========================================
+ Hits 10672 10674 +2
+ Misses 3514 3513 -1
+ Partials 790 788 -2
Continue to review full report at Codecov.
|
briandealwis
approved these changes
Mar 16, 2021
|
ignoring the checks as the branch was created from master using Github UI |
This was referenced Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing Code walks, @IsaacPD mentioned, both "flag_value" and "value" are duplicates and used for recording flag value
Removing "value" in favor of the other.