-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skaffold debug
should use debugpy for Python
#5576
Conversation
} | ||
|
||
func hasPyModule(module string, args []string) bool { | ||
if index := util.StrSliceIndex(args, "-m"+module); index >= 0 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit for consistency:
if index := util.StrSliceIndex(args, "-m"+module); index >= 0 { | |
if index := util.StrSliceIndex(args, fmt.Sprintf("-m%s", module)); index >= 0 { |
Codecov Report
@@ Coverage Diff @@
## master #5576 +/- ##
==========================================
- Coverage 71.25% 71.03% -0.23%
==========================================
Files 400 402 +2
Lines 14975 15096 +121
==========================================
+ Hits 10671 10724 +53
- Misses 3514 3578 +64
- Partials 790 794 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Fixes: #4437
Description
This PR switches
skaffold debug
to usedebugpy
for Python from the now-deprecatedptvsd
. It recognizes ifptvsd
ordebugpy
is already in use.debugpy
has been part of the debug helper images for a while now.User facing changes (remove if N/A)
skaffold debug
now usesdebugpy
for Python.