Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating custom test documentation #5606

Merged
merged 2 commits into from
Mar 31, 2021
Merged

Updating custom test documentation #5606

merged 2 commits into from
Mar 31, 2021

Conversation

PriyaModali
Copy link
Contributor

@PriyaModali PriyaModali commented Mar 25, 2021 •
edited
Loading

Fixes: #5604

Update custom test documentation

Description
Updating custom test documentation.

@PriyaModali PriyaModali added kind/documentation priority/p1 High impact feature/bug. labels Mar 25, 2021
@PriyaModali PriyaModali requested a review from a team as a code owner March 25, 2021 21:52
@google-cla google-cla bot added the cla: yes label Mar 25, 2021
@PriyaModali PriyaModali marked this pull request as draft March 25, 2021 21:52
@codecov
Copy link

codecov bot commented Mar 25, 2021 •
edited
Loading

Codecov Report

Merging #5606 (ad640d2) into master (8b4cfda) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5606      +/-   ##
==========================================
- Coverage   71.09%   71.08%   -0.01%     
==========================================
  Files         402      402              
  Lines       15183    15169      -14     
==========================================
- Hits        10794    10783      -11     
+ Misses       3596     3595       -1     
+ Partials      793      791       -2
Impacted Files Coverage Δ
pkg/skaffold/build/custom/script.go 51.16% <0.00%> (-1.11%) ⬇️
pkg/skaffold/tag/tag.go 100.00% <0.00%> (ø)
pkg/skaffold/tag/env_template.go 100.00% <0.00%> (ø)
pkg/skaffold/event/event.go 91.10% <0.00%> (+0.03%) ⬆️
pkg/skaffold/docker/image.go 79.53% <0.00%> (+1.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b4cfda...ad640d2. Read the comment docs.

@gsquared94 gsquared94 added the docs-modifications runs the docs preview service on the given PR label Mar 29, 2021
@container-tools-bot
Copy link

Please visit http://34.94.115.108:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Mar 29, 2021
@viglesiasce
Copy link
Contributor

Looks good to me!

gsquared94
gsquared94 approved these changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@gsquared94 gsquared94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@PriyaModali PriyaModali marked this pull request as ready for review March 30, 2021 23:33
@PriyaModali PriyaModali merged commit e9bc32e into GoogleContainerTools:master Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsquared94 gsquared94 gsquared94 approved these changes

Assignees
No one assigned
Labels
cla: yes kind/documentation priority/p1 High impact feature/bug. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update custom test documentation
4 participants
@PriyaModali @container-tools-bot @viglesiasce @gsquared94