Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document portforwarding behavior for system ports #5680

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Document portforwarding behavior for system ports #5680

merged 1 commit into from
Apr 15, 2021

Conversation

gsquared94
Copy link
Contributor

Related: #5670

@gsquared94 gsquared94 requested a review from a team as a code owner April 15, 2021 00:29
@google-cla google-cla bot added the cla: yes label Apr 15, 2021
@gsquared94 gsquared94 requested a review from priyawadhwa April 15, 2021 00:29
@gsquared94 gsquared94 added the docs-modifications runs the docs preview service on the given PR label Apr 15, 2021
@container-tools-bot
Copy link

Please visit http://35.236.21.86:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Apr 15, 2021
@gsquared94
Copy link
Contributor Author

image

@gsquared94 gsquared94 requested review from PriyaModali and removed request for priyawadhwa April 15, 2021 00:32
@codecov
Copy link

codecov bot commented Apr 15, 2021 •
edited
Loading

Codecov Report

Merging #5680 (9503942) into master (32a0416) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5680   +/-   ##
=======================================
  Coverage   70.70%   70.70%           
=======================================
  Files         411      411           
  Lines       15805    15805           
=======================================
  Hits        11175    11175           
  Misses       3809     3809           
  Partials      821      821

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32a0416...9503942. Read the comment docs.

@gsquared94
Copy link
Contributor Author

unrelated test flakes

@gsquared94 gsquared94 merged commit 6ba9be2 into GoogleContainerTools:master Apr 15, 2021
tejal29
tejal29 reviewed Apr 15, 2021
View reviewed changes
Copy link
Contributor

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tejal29 tejal29 tejal29 left review comments

@PriyaModali PriyaModali Awaiting requested review from PriyaModali

Assignees
No one assigned
Labels
cla: yes size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gsquared94 @container-tools-bot @tejal29