Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit TaskEvents Protos for PortForwarding #5689

Merged
merged 8 commits into from
Apr 23, 2021

Conversation

MarlonGamez
Copy link
Contributor

Fixes: #5422
Related: #5368 #5422

Description
Emit taskevent protos on v2 endpoints

User facing changes (remove if N/A)
Users can now use the v2 event API to see the start, end, or failure of the portforward phase

@MarlonGamez MarlonGamez requested a review from a team as a code owner April 15, 2021 18:38
@google-cla google-cla bot added the cla: yes label Apr 15, 2021
@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #5689 (2d4618e) into master (21debe2) will increase coverage by 0.09%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5689      +/-   ##
==========================================
+ Coverage   70.74%   70.84%   +0.09%     
==========================================
  Files         421      421              
  Lines       16037    16043       +6     
==========================================
+ Hits        11346    11366      +20     
+ Misses       3858     3845      -13     
+ Partials      833      832       -1     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/flags.go 89.02% <ø> (ø)
pkg/skaffold/config/options.go 100.00% <ø> (ø)
...affold/kubernetes/portforward/forwarder_manager.go 52.38% <0.00%> (+19.04%) ⬆️
pkg/skaffold/runner/portforwarder.go 22.22% <ø> (+2.22%) ⬆️
pkg/skaffold/runner/runner.go 0.00% <ø> (ø)
pkg/skaffold/runner/build_deploy.go 69.23% <60.00%> (ø)
pkg/skaffold/runner/dev.go 71.82% <62.50%> (ø)
pkg/skaffold/runner/deploy.go 53.60% <80.00%> (ø)
pkg/skaffold/build/builder_mux.go 48.78% <84.61%> (+4.04%) ⬆️
pkg/skaffold/event/v2/event.go 73.73% <100.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5698dea...2d4618e. Read the comment docs.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Apr 15, 2021
@MarlonGamez MarlonGamez marked this pull request as draft April 20, 2021 23:15
@MarlonGamez MarlonGamez marked this pull request as ready for review April 21, 2021 00:07
@MarlonGamez MarlonGamez requested a review from tejal29 April 21, 2021 20:57
@pull-request-size pull-request-size bot added size/L and removed size/M labels Apr 22, 2021
@MarlonGamez MarlonGamez added this to the v1.23.0 milestone Apr 22, 2021
@MarlonGamez MarlonGamez added the kokoro:run runs the kokoro jobs on a PR label Apr 22, 2021
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Apr 22, 2021
@MarlonGamez MarlonGamez merged commit 9b59cbc into GoogleContainerTools:master Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have skaffold emit TaskEvent protos
3 participants