Add emission of TestSubtaskEvents #5816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5816 +/- ##
==========================================
+ Coverage 71.00% 71.05% +0.04%
==========================================
Files 438 440 +2
Lines 16497 16532 +35
==========================================
+ Hits 11714 11746 +32
- Misses 3921 3923 +2
- Partials 862 863 +1
Continue to review full report at Codecov.
|
nkubala
reviewed
May 11, 2021
| @@ -370,6 +370,11 @@ func (ev *eventHandler) handleExec(event *proto.Event) { | |||
| ev.stateLock.Lock() | |||
| ev.state.BuildState.Artifacts[be.Artifact] = be.Status | |||
| ev.stateLock.Unlock() | |||
| case *proto.Event_TestEvent: | |||
| te := e.TestEvent | |||
There was a problem hiding this comment.
why we need these intermediate vars?
There was a problem hiding this comment.
don't think we do, this is mostly just a result of me copying from the previous event API 😅 I can make a follow up PR to clean this up a bit!
nkubala
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5784
Related: #5423
Description
Adds emission of
TestSubtaskEvents when tests start, finish, or failUser facing changes (remove if N/A)
Users can now see events that correlate to start, failure, and finish of tests in skaffold
Follow-up Work (remove if N/A)
Put more detail in these events. The initial definition doesn't have much meta info about the test running, but I'd like to update it with more information.