-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose --event-log-file to render, apply, and test #5828
Expose --event-log-file to render, apply, and test #5828
Conversation
Code change LGTM, I believe doc generation needs to be re-run here -
|
Docs regenerated @aaron-prindle |
Codecov Report
@@ Coverage Diff @@
## master #5828 +/- ##
==========================================
- Coverage 70.99% 70.95% -0.05%
==========================================
Files 440 440
Lines 16572 16582 +10
==========================================
Hits 11765 11765
- Misses 3939 3949 +10
Partials 868 868
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like we discussed in the standup, please mark the flag hidden.
Flag is now hidden. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I restarted the flaked CI job but feel free and merge when green
Fixes #5831 #5833 #5834
Related to: #5125
Description
#5125 added the ability to log events to a file for
dev
,build
,run
,debug
,deploy
. It would be useful to have this available forrender
,apply
, andtest
.This PR adds
--event-log-file
and--enable-rpc
forrender
,apply
, andtest
. It also marks the flag as hidden: it was intended as an internal tool for integration tests:Follow-up Work (remove if N/A)
--enable-rpc